Reorder DayOfWeek members #6749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the members in a more sensible order that both reflects the raw value order as well as match at last one common calendaring system (it could start with Monday though)
ghost
added
the
|
|
|
Docs Build status updates of commit 68acb4f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
ping @gewarren @joelmartinez This change looks good, but I want to know if it will be overridden by the mdoc build in future releases. |
|
Unfortunately this will get overwritten the next time we update the APIs, so I'll have to close this PR. So, the same fate as #4558. We do have an internal work item tracking a feature that would let customers sort enum fields either by value or alphabetically. |
This was referenced Mar 8, 2023
|
This has been fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The documentation for the DayOfWeek enumeration currently has a bit of a weird order. It's not based on the underlying value, nor is it based on common order of days as it would appear on a calendar, nor is it alphabetical.
I believe the changes in this pull request will put the values in the order Sunday, Monday, Tuesday, Wednesday, Thursday, Friday, Saturday. Not sure if that's controversial or not, but an alternate could be done with the week starting on Monday.